`Say` command sometimes includes movement command strings

[jdolan]

There is some sort of buffer overflow or missing termination on message_mode. Occasionally, a client will say something in chat, and their most recent (?) movement command will be appended to the end of their message for all to see.

[jdolan]

Test ticket update.

[jdolan]

bind m "+attack; wait; -attack; use grenade launcher; +attack; wait; -attack; use railgun; +attack; wait; -attack;"

This will reproduce the bug every time.

[jdolan]

r1690 has been committed against this. What I found was happening is binds that start with a '+' must include keysym and time parameters to their command (e.g. +forward 109 123456). This is so the input code or server can know definitively when these commands were generated. Unfortunately, this doesn't work well with complex binds (bind f +attack; - attack; use this; +attack; -attack; use that;). Obviously, this sort of bind shouldn't have the keysym and time appended to it -- it makes no sense. So complex binds are now disallowed, and folks should use aliases for these types of things from now on. I also rewrote Cmd_TokenizeString to be safer.

Will have to wait and see if the issue is squashed.

[jdolan]

I can't reproduce this with HEAD.